-
-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support 2022.2 #517
Support 2022.2 #517
Conversation
@chbndrhnns @KotlinIsland |
Codecov Report
@@ Coverage Diff @@
## master #517 +/- ##
============================================
- Coverage 74.51% 0.00% -74.52%
============================================
Files 23 23
Lines 1801 1799 -2
Branches 518 532 +14
============================================
- Hits 1342 0 -1342
- Misses 193 1799 +1606
+ Partials 266 0 -266
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
gradle.properties
Outdated
|
||
# Plugin Dependencies -> https://plugins.jetbrains.com/docs/intellij/plugin-dependencies.html | ||
# Example: platformPlugins = com.intellij.java, com.jetbrains.php:203.4449.22 | ||
platformPlugins = python-ce | ||
|
||
# Java language level used to compile sources and to generate the files for - Java 11 is required since 2020.3 | ||
javaVersion = 11 | ||
languageVersion = 1.7 | ||
apiVersion = 1.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are targeting 222 as a minimum, then we should be using api 1.7 and java 11, I think we should a toolchain here like in the plugin template project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the config. But, Jacoco doesn't cover any test cases 😢 |
Oh sorry!, I made a mistake, 2022.2 has Java 17, not java 11. If we are targeting 222 as a minimum we should have Java 17 |
I found the issue 😭 |
Maybe we could use kotlinx-kover instead? |
Related Issues
#492
#494
#516
#511